Skip to content

优化陶瓦联机反馈提示#6120

Open
CiiLu wants to merge 2 commits into
HMCL-dev:mainfrom
CiiLu:ee
Open

优化陶瓦联机反馈提示#6120
CiiLu wants to merge 2 commits into
HMCL-dev:mainfrom
CiiLu:ee

Conversation

@CiiLu
Copy link
Copy Markdown
Contributor

@CiiLu CiiLu commented May 17, 2026

右侧列表内的是随机展示的,和更新没关系
image

@Glavo
Copy link
Copy Markdown
Member

Glavo commented May 18, 2026

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the feedback confirmation dialog to use a new localization key, terracotta.feedback.desc.update, and introduces a shorter version for the existing terracotta.feedback.desc key across several language files. A critical issue was identified in the Arabic localization file where the original key was renamed but not replaced, potentially leading to a MissingResourceException if the old key is still required by the application.

Comment thread HMCL/src/main/resources/assets/lang/I18N_ar.properties
@Glavo Glavo requested a review from burningtnt May 18, 2026 12:32
Copy link
Copy Markdown
Member

@burningtnt burningtnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有看出这样改的必要,但同样没有想到不这样改的必要

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants